secure set manifest endpoint #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
force-pushed
the
feat/secure-set-manifest-endpoint
branch
from
d91b12b to
fc61ae2
Compare
This allows the use of mTLS with clients that use regular TLS certs and enables optional TLS verification of selected RPCs.
malt3
force-pushed
the
feat/secure-set-manifest-endpoint
branch
from
fce783c to
b8c2199
Compare
Validates client certificate according to the following state machine: - In the initial state, with no manifest set, cert validation is not performed and a client cert is optional - Afterwards, clients need to send a cert with a public key that is included in the manifests list of workload owner keys - An empty list of workload owner keys in the manifests prevents any manifest updates
malt3
force-pushed
the
feat/secure-set-manifest-endpoint
branch
from
b8c2199 to
0ea6f4c
Compare
katexochen
approved these changes
Feb 9, 2024
katexochen
force-pushed
the
main
branch
2 times, most recently
from
2aaf78e to
5b4eb97
Compare
3u13r
requested changes
Feb 9, 2024
malt3
force-pushed
the
feat/secure-set-manifest-endpoint
branch
from
0ea6f4c to
4da3adf
Compare
3u13r
requested changes
Feb 12, 2024
malt3
force-pushed
the
feat/secure-set-manifest-endpoint
branch
from
4da3adf to
49201d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements rfc 002.